New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] fix constructor args check #20882

Merged
merged 1 commit into from Dec 13, 2016

Conversation

Projects
None yet
3 participants
@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2016

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/symfony-docs#7242
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.2 milestone Dec 12, 2016

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 13, 2016

Thanks for fixing this bug @xabbuh.

@fabpot fabpot merged commit fa82588 into symfony:3.2 Dec 13, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 13, 2016

bug #20882 [TwigBridge] fix constructor args check (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[TwigBridge] fix constructor args check

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-docs#7242
| License       | MIT
| Doc PR        |

Commits
-------

fa82588 [TwigBridge] fix constructor args check

@xabbuh xabbuh deleted the xabbuh:docs-7242 branch Dec 13, 2016

@fabpot fabpot referenced this pull request Dec 13, 2016

Merged

Release v3.2.1 #20897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment