New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] fix group sequence based validation #20975

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Projects
None yet
4 participants
@xabbuh
Member

xabbuh commented Dec 17, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20929
License MIT
Doc PR
$options = array('validation_groups' => array($this, 'getValidationGroups'));
$form = $this->getBuilder('name', '\stdClass', $options)
->setData($object)
->getForm();
$this->expectValidateAt(0, 'data', $object, 'group1');
$this->expectValidateAt(1, 'data', $object, 'group2');
$this->expectValidateAt(0, 'data', $object, array('group1', 'group2'));

This comment has been minimized.

@HeahDude

HeahDude Dec 19, 2016

Member

Looks like this bug fix is breaking BC with this behavioral change. But it seems the code was broken so I'm still 👍 for this one.

@HeahDude

HeahDude Dec 19, 2016

Member

Looks like this bug fix is breaking BC with this behavioral change. But it seems the code was broken so I'm still 👍 for this one.

This comment has been minimized.

@xabbuh

xabbuh Dec 19, 2016

Member

@HeahDude Which BC break do you refer to?

@xabbuh

xabbuh Dec 19, 2016

Member

@HeahDude Which BC break do you refer to?

This comment has been minimized.

@HeahDude

HeahDude Dec 19, 2016

Member

Arff, got confused by your refactoring :)

@HeahDude

HeahDude Dec 19, 2016

Member

Arff, got confused by your refactoring :)

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 19, 2016

Member

Thank you @xabbuh.

Member

fabpot commented Dec 19, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit fb91f74 into symfony:2.7 Dec 19, 2016

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 19, 2016

bug #20975 [Form] fix group sequence based validation (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] fix group sequence based validation

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20929
| License       | MIT
| Doc PR        |

Commits
-------

fb91f74 [Form] fix group sequence based validation

@xabbuh xabbuh deleted the xabbuh:issue-20929 branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment