New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService #21032

Merged
merged 1 commit into from Dec 31, 2016

Conversation

Projects
None yet
5 participants
@lyrixx
Member

lyrixx commented Dec 23, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Dec 29, 2016

Member

Fabbot is wrong.
Tests are green ;)

Member

lyrixx commented Dec 29, 2016

Fabbot is wrong.
Tests are green ;)

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Dec 29, 2016

Member

When can the collection be non-unique? Can we add a test covering this?

Member

xabbuh commented Dec 29, 2016

When can the collection be non-unique? Can we add a test covering this?

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Dec 29, 2016

Member

When can the collection be non-unique?

If you have many authentication provider in a firewall that use the same user provider

Can we add a test covering this?

yes, I guess ;)

Member

lyrixx commented Dec 29, 2016

When can the collection be non-unique?

If you have many authentication provider in a firewall that use the same user provider

Can we add a test covering this?

yes, I guess ;)

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Dec 30, 2016

Member

I wanted to add tests, but for now, there are no tests on this class. IMHO, we can merge this one as this.

Member

lyrixx commented Dec 30, 2016

I wanted to add tests, but for now, there are no tests on this class. IMHO, we can merge this one as this.

@xabbuh

xabbuh approved these changes Dec 30, 2016

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 31, 2016

Member

Thank you @lyrixx.

Member

fabpot commented Dec 31, 2016

Thank you @lyrixx.

@fabpot fabpot merged commit 8227593 into symfony:2.7 Dec 31, 2016

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Dec 31, 2016

bug #21032 [SecurityBundle] Made collection of user provider unique w…
…hen injecting them to the RemberMeService (lyrixx)

This PR was merged into the 2.7 branch.

Discussion
----------

[SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

8227593 [SecurityBundle] Made collection of user provider unique when injecting them to the RemberMeService

@lyrixx lyrixx deleted the lyrixx:secu-remember-me branch Jan 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment