New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] handle empty lines inside unindented collection #21084

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
5 participants
@xabbuh
Member

xabbuh commented Dec 28, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21005
License MIT
Doc PR
@chalasr

This comment has been minimized.

Show comment
Hide comment
@chalasr

chalasr Dec 29, 2016

Member

👍

Status: reviewed

Member

chalasr commented Dec 29, 2016

👍

Status: reviewed

@xabbuh xabbuh added this to the 2.7 milestone Dec 31, 2016

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jan 3, 2017

Member

👍

Member

stof commented Jan 3, 2017

👍

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jan 3, 2017

Member

Thank you @xabbuh.

Member

fabpot commented Jan 3, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit bbfe6f7 into symfony:2.7 Jan 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 3, 2017

bug #21084 [Yaml] handle empty lines inside unindented collection (xa…
…bbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] handle empty lines inside unindented collection

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21005
| License       | MIT
| Doc PR        |

Commits
-------

bbfe6f7 handle empty lines inside unindented collection

@xabbuh xabbuh deleted the xabbuh:issue-21005 branch Jan 3, 2017

fabpot added a commit that referenced this pull request Jan 8, 2017

feature #21114 [Yaml] parse multi-line strings (xabbuh)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Yaml] parse multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

When working on #21084, I discovered that the YAML parser does not support (unquoted) multi-line strings (neither as plain strings nor as values for mappings). This PR adds support for them.

Commits
-------

ec593b9 [Yaml] parse multi-line strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment