[Ldap] Ldap username case fix #21291

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@quentinus95
Contributor
quentinus95 commented Jan 14, 2017 edited
Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20486
License MIT
Doc PR
quentinus95 added some commits Nov 17, 2016
@quentinus95 quentinus95 [Ldap] load users with the good username case
4e46bcc
@quentinus95 quentinus95 [Ldap] Using Ldap stored username instead of form submitted one
5a0afcf
@quentinus95
Contributor

@csarrazi I have recreated a new PR and deleted the old one because I merged the whole master branch in it inadvertently (I forgot it was based on 3.1)

I have removed the null check in getAttributeValue method and set a default value for $uidKey if null given. I also set the password to null if the password attribute is null.

@quentinus95 quentinus95 changed the title from Ldap case fix to [Ldap] Ldap username case fix Jan 14, 2017
@nicolas-grekas
Member

Which branch is this fix for? There's a mismatch between the description and the selected base branch (no need to change because we can while merging.)

@quentinus95
Contributor

This fix is for the 3.1 branch, sorry!

@nicolas-grekas nicolas-grekas added this to the 3.1 milestone Jan 16, 2017
@nicolas-grekas
Member

ping @csarrazi (3.1 is EOLed in two weeks)

@csarrazi
Contributor
csarrazi commented Jan 16, 2017 edited

👍 , as I said in the previous PR. I would merge it against 3.1, as we still support it (even though EOL is in 2 weeks).

@quentinus95
Contributor

Should I care about the failure on AppVeyor as it does not seems related to the changes of this PR ?

@fabpot
Member
fabpot commented Jan 17, 2017

Thank you @quentinus95.

@fabpot fabpot added a commit that referenced this pull request Jan 17, 2017
@fabpot fabpot bug #21291 [Ldap] Ldap username case fix (quentinus95)
This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes #21291).

Discussion
----------

[Ldap] Ldap username case fix

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20486
| License       | MIT
| Doc PR        |

Commits
-------

c91689b [Ldap] Using Ldap stored username instead of form submitted one
6641b79 [Ldap] load users with the good username case
0dd6a90
@fabpot fabpot closed this Jan 17, 2017
This was referenced Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment