[Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered #21311

Merged
merged 1 commit into from Jan 16, 2017

Projects

None yet

3 participants

@skalpa
skalpa commented Jan 16, 2017
Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21304
License MIT
Doc PR -

Prevents a fatal error when setting a new logger if the bootstrapping logger buffered an exception that does not extend ErrorException.

@nicolas-grekas The faulty behaviour was added by 8f24549, so this PR is against 3.2 and not 2.8.

skalpa [Debug] Fix fatal error when changing ErrorHandler loggers if an exce…
…ption is buffered
a6527f8
@nicolas-grekas nicolas-grekas added this to the 3.2 milestone Jan 16, 2017
@nicolas-grekas
Member

👍

@nicolas-grekas nicolas-grekas changed the title from [Debug] Fix fatal error when changing ErrorHandler loggers if an exce… to [Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered Jan 16, 2017
@nicolas-grekas
Member

Good catch, thanks @skalpa.

@nicolas-grekas nicolas-grekas merged commit a6527f8 into symfony:3.2 Jan 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas added a commit that referenced this pull request Jan 16, 2017
@nicolas-grekas nicolas-grekas bug #21311 [Debug] Fix fatal error when changing ErrorHandler loggers…
… if an exception is buffered (skalpa)

This PR was merged into the 3.2 branch.

Discussion
----------

[Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21304
| License       | MIT
| Doc PR        | -

Prevents a fatal error when setting a new logger if the bootstrapping logger buffered an exception that does not extend `ErrorException`.

@nicolas-grekas The faulty behaviour was added by 8f24549, so this PR is against 3.2 and not 2.8.

Commits
-------

a6527f8 [Debug] Fix fatal error when changing ErrorHandler loggers if an exception is buffered
87dcda8
@fabpot fabpot referenced this pull request Feb 6, 2017
Merged

Release v3.2.3 #21544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment