[PhpUnit] Blacklist DeprecationErrorHandler in stack traces #21336

Merged
merged 1 commit into from Jan 18, 2017

Projects

None yet

5 participants

@nicolas-grekas
Member
Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

So that phpunit doesn't tell about DeprecationErrorHandler in failure's stack traces.

@nicolas-grekas nicolas-grekas [PhpUnit] Blacklist DeprecationErrorHandler in stack traces
3f693ae
@nicolas-grekas nicolas-grekas added this to the 3.2 milestone Jan 18, 2017
@sstok
Contributor
sstok commented Jan 18, 2017

Yes please, whenever using PHPStorm go to declaration it opens the DeprecationErrorHandler and not the actual test 🤦‍♂️

@stof
Member
stof commented Jan 18, 2017

👍

@fabpot
Member
fabpot commented Jan 18, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 3f693ae into symfony:3.2 Jan 18, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@fabpot fabpot added a commit that referenced this pull request Jan 18, 2017
@fabpot fabpot bug #21336 [PhpUnit] Blacklist DeprecationErrorHandler in stack trace…
…s (nicolas-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[PhpUnit] Blacklist DeprecationErrorHandler in stack traces

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

So that phpunit doesn't tell about DeprecationErrorHandler in failure's stack traces.

Commits
-------

3f693ae [PhpUnit] Blacklist DeprecationErrorHandler in stack traces
6283fc4
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:phpunit-blacklist branch Jan 22, 2017
@fabpot fabpot referenced this pull request Feb 6, 2017
Merged

Release v3.2.3 #21544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment