Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Generalize constructor autowiring to partial method calls #21404

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
4 participants
@nicolas-grekas
Copy link
Member

commented Jan 25, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

When autowiring is enabled:

currently, the constructor can be partially wired, and autowiring will complete the remaining missing arguments.
But there is no reason this should only apply to the constructor.
This PR fixes this inconsistency by looking at all method calls, and wire missing arguments in the same way.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Jan 25, 2017

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:autow-partials branch from f8af196 to 29c2fd5 Jan 25, 2017

@dunglas

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

👍

@stof

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

looks good to me

@fabpot

This comment has been minimized.

Copy link
Member

commented Jan 25, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 29c2fd5 into symfony:master Jan 25, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 25, 2017

feature #21404 [DI] Generalize constructor autowiring to partial meth…
…od calls (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Generalize constructor autowiring to partial method calls

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

When autowiring is enabled:

currently, the constructor can be partially wired, and autowiring will complete the remaining missing arguments.
But there is no reason this should only apply to the constructor.
This PR fixes this inconsistency by looking at all method calls, and wire missing arguments in the same way.

Commits
-------

29c2fd5 [DI] Generalize constructor autowiring to partial method calls

@nicolas-grekas nicolas-grekas moved this from In Review to Done in Lower entry bar Jan 26, 2017

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:autow-partials branch Jan 30, 2017

@fabpot fabpot referenced this pull request May 1, 2017

Merged

Release v3.3.0-BETA1 #22603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.