Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[DependencyInjection] check for circular refs caused by method calls #21436
Before we check for circular references, dependencies coming from method calls are not part of the dependency graph. That why the pass is not able to detect circular references like the one described in #19362 during compilation of the container.
If we add another check after all the optimisation passes have been processed, we should be able to detect these circular references too.
Feb 16, 2017
referenced this pull request
Feb 17, 2017
Resubmitted in #21642 (I opened the PR against