Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Deprecate not inheriting env vars + compat related settings #21470

Merged
merged 1 commit into from Feb 1, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jan 31, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

Turning compat on/off is not a feature in itself.

About env vars: if one has unwanted env vars, one will still be able to remove them explicitly for the command. From my experience, not having eg PATH or HTTP_PROXY, etc. is more problematic. I'd prefer people to care about setting/unsetting the environment vars they know about, rather than allowing them to start with no ENV and discover later that they missed setting some var.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:proc-deprec branch from 5480557 to df14451 Jan 31, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit df14451 into symfony:master Feb 1, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 1, 2017

feature #21470 [Process] Deprecate not inheriting env vars + compat r…
…elated settings (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Process] Deprecate not inheriting env vars + compat related settings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Turning compat on/off is not a feature in itself.

About env vars: if one has unwanted env vars, one will still be able to remove them explicitly for the command. From my experience, not having eg PATH or HTTP_PROXY, etc. is more problematic. I'd prefer people to care about setting/unsetting the environment vars **they know about**, rather than allowing them to start with no ENV and discover later that they missed setting some var.

Commits
-------

df14451 [Process] Deprecate not inheriting env vars + compat related settings
@@ -1099,15 +1103,7 @@ public function getEnv()
*/
public function setEnv(array $env)
{
// Process can not handle env values that are arrays

This comment has been minimized.

Copy link
@stof

stof Feb 2, 2017

Member

We need to trigger a deprecation warning when passing array values (this was added because some people were passing $_SERVER directly at some point, when inheriting was not a native feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.