[Cache] Fix class exists checks in PhpArrayAdapter #21528

Merged
merged 1 commit into from Feb 5, 2017

Projects

None yet

3 participants

@nicolas-grekas
Member
Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Fixes HHVM, as spotted in #21527

@nicolas-grekas nicolas-grekas [Cache] Fix class exists checks in PhpArrayAdapter
44e5989
@nicolas-grekas nicolas-grekas added this to the 3.2 milestone Feb 4, 2017
@nicolas-grekas nicolas-grekas merged commit 44e5989 into symfony:3.2 Feb 5, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas added a commit that referenced this pull request Feb 5, 2017
@nicolas-grekas nicolas-grekas bug #21528 [Cache] Fix class exists checks in PhpArrayAdapter (nicola…
…s-grekas)

This PR was merged into the 3.2 branch.

Discussion
----------

[Cache] Fix class exists checks in PhpArrayAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes HHVM, as spotted in #21527

Commits
-------

44e5989 [Cache] Fix class exists checks in PhpArrayAdapter
081f7b4
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-fix branch Feb 5, 2017
@fabpot fabpot referenced this pull request Feb 6, 2017
Merged

Release v3.2.3 #21544

@@ -373,15 +373,15 @@ private function generateItems(array $keys)
*/
public static function throwOnRequiredClass($class)
{
- $e = new \ReflectionException(sprintf('Class %s does not exist', $class));
+ $e = new \ReflectionException("Class $class does not exist");
@jakzal
jakzal Feb 9, 2017 Member

"Exception and error message strings must be concatenated using sprintf;" ;) http://symfony.com/doc/current/contributing/code/standards.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment