New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console][Table] fixed render when using multiple rowspans. #21599

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
3 participants
@aitboudad
Contributor

aitboudad commented Feb 13, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21018
License MIT
Doc PR ~
Show outdated Hide outdated src/Symfony/Component/Console/Helper/Table.php
@@ -394,6 +394,9 @@ private function fillNextRows($rows, $line)
foreach ($unmergedRows as $unmergedRowKey => $unmergedRow) {
$value = isset($lines[$unmergedRowKey - $line]) ? $lines[$unmergedRowKey - $line] : '';
$unmergedRows[$unmergedRowKey][$column] = new TableCell($value, array('colspan' => $cell->getColspan()));
if ($nbLines === ($unmergedRowKey - $line)) {

This comment has been minimized.

@fabpot

fabpot Feb 14, 2017

Member

parentheses can be removed.

@fabpot

fabpot Feb 14, 2017

Member

parentheses can be removed.

This comment has been minimized.

@aitboudad

aitboudad Feb 14, 2017

Contributor

done

@aitboudad

aitboudad Feb 14, 2017

Contributor

done

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Feb 16, 2017

Member

Thank you @aitboudad.

Member

fabpot commented Feb 16, 2017

Thank you @aitboudad.

@fabpot fabpot merged commit 17e459e into symfony:2.7 Feb 16, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 16, 2017

bug #21599 [Console][Table] fixed render when using multiple rowspans…
…. (aitboudad)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console][Table] fixed render when using multiple rowspans.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21018
| License       | MIT
| Doc PR        | ~

Commits
-------

17e459e [Console][Table] fixed render when using multiple rowspans.

@aitboudad aitboudad deleted the aitboudad:issues_21018 branch Feb 16, 2017

@fabpot fabpot referenced this pull request Feb 17, 2017

Merged

Release v3.2.4 #21640

This was referenced Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment