New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Permit empty suffix on Windows #21613

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Bilge
Contributor

Bilge commented Feb 14, 2017

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

It is a fallacy to assume the blank suffix is not applicable on Windows systems, especially in a world where we often emulate Linux systems with solutions such as CYGWIN, MinGW and MSYS.

@@ -75,7 +75,7 @@ public function find($name, $default = null, array $extraDirs = array())
$suffixes = array('');
if ('\\' === DIRECTORY_SEPARATOR) {
$pathExt = getenv('PATHEXT');
$suffixes = $pathExt ? explode(PATH_SEPARATOR, $pathExt) : $this->suffixes;
$suffixes = array_merge($suffixes, $pathExt ? explode(PATH_SEPARATOR, $pathExt) : $this->suffixes);

This comment has been minimized.

@Bilge

Bilge Feb 14, 2017

Contributor

Here we are merging the Windows suffixes with the previously-defined empty suffix on line 75, instead of overwriting the empty suffix list as previously.

@Bilge

Bilge Feb 14, 2017

Contributor

Here we are merging the Windows suffixes with the previously-defined empty suffix on line 75, instead of overwriting the empty suffix list as previously.

@Bilge Bilge changed the title from Permit empty suffix on Windows to [Process] Permit empty suffix on Windows Feb 14, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Feb 16, 2017

Member

Thank you @Bilge.

Member

fabpot commented Feb 16, 2017

Thank you @Bilge.

fabpot added a commit that referenced this pull request Feb 16, 2017

bug #21613 [Process] Permit empty suffix on Windows (Bilge)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21613).

Discussion
----------

[Process] Permit empty suffix on Windows

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

It is a fallacy to assume the blank suffix is not applicable on Windows systems, especially in a world where we often emulate Linux systems with solutions such as CYGWIN, MinGW and MSYS.

Commits
-------

412db4c Permit empty suffix on Windows

@fabpot fabpot closed this Feb 16, 2017

@Bilge

This comment has been minimized.

Show comment
Hide comment
@Bilge

Bilge Feb 16, 2017

Contributor

Thank you @fabpot 👍

Contributor

Bilge commented Feb 16, 2017

Thank you @fabpot 👍

@fabpot fabpot referenced this pull request Feb 17, 2017

Merged

Release v3.2.4 #21640

This was referenced Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment