Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] fix priority ordering of security voters #21679

Merged
merged 1 commit into from Feb 22, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 20, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21660
License MIT
Doc PR

Could be updated in the 3.2 branch to make use of the PriorityTaggedServiceTrait .

@fabpot
Copy link
Member

fabpot commented Feb 22, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit dcd19f3 into symfony:2.7 Feb 22, 2017
fabpot added a commit that referenced this pull request Feb 22, 2017
…(xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[SecurityBundle] fix priority ordering of security voters

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21660
| License       | MIT
| Doc PR        |

Could be updated in the `3.2` branch to make use of the `PriorityTaggedServiceTrait `.

Commits
-------

dcd19f3 fix priority ordering of security voters
@fabpot
Copy link
Member

fabpot commented Feb 22, 2017

see #21709 for a followup on 3.2.

@xabbuh xabbuh deleted the issue-21660 branch February 22, 2017 05:42
fabpot added a commit that referenced this pull request Feb 23, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

[SecurityBundle] simplified code

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Simplified code for 3.2 (followup to #21679)

Commits
-------

512742b [SecurityBundle] simplified code
This was referenced Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants