Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][PropertyInfo] Move PropertyInfoPass to the PropertyInfo component #21806

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

commented Feb 28, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@chalasr chalasr referenced this pull request Feb 28, 2017

Closed

[FrameworkBundle] Move compiler passes to their component #21284

11 of 11 tasks complete

@chalasr chalasr force-pushed the chalasr:propertyinfopass branch from d146d6a to 558ed10 Feb 28, 2017

private $descriptionExtractorTag;
private $accessExtractorTag;
public function __construct($propertyInfoService = 'property_info', $listExtractorTag = 'property_info.list_extractor', $typeExtractorTag = 'property_info.type_extractor', $descriptionExtractorTag = 'property_info.description_extractor', $accessExtractorTag = 'property_info.access_extractor')

This comment has been minimized.

Copy link
@GuilhemN

GuilhemN Feb 28, 2017

Contributor

Is this kind of extension point really needed?

This comment has been minimized.

Copy link
@chalasr

chalasr Feb 28, 2017

Author Member

Yes I think, we did it for each other (see #20250 (comment))

This comment has been minimized.

Copy link
@ogizanagi

ogizanagi Feb 28, 2017

Member

Why not? It allows configuring multiple property info services in an application easily.

This comment has been minimized.

Copy link
@GuilhemN

GuilhemN Feb 28, 2017

Contributor

It adds stuff to maintain and I'm not sure it's really useful, but if you think it is why not.

@chalasr chalasr force-pushed the chalasr:propertyinfopass branch from 558ed10 to 7a7ff24 Mar 1, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 7a7ff24 into symfony:master Mar 1, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 1, 2017

feature #21806 [FrameworkBundle][PropertyInfo] Move PropertyInfoPass …
…to the PropertyInfo component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][PropertyInfo] Move PropertyInfoPass to the PropertyInfo component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

7a7ff24 Move PropertyInfoPass to the PropertyInfo component

@chalasr chalasr deleted the chalasr:propertyinfopass branch Mar 1, 2017

@fabpot fabpot referenced this pull request May 1, 2017

Merged

Release v3.3.0-BETA1 #22603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.