Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component #21835

Merged
merged 1 commit into from Mar 5, 2017

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

commented Mar 2, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
@trigger_error(sprintf('The %s class is deprecated since version 3.3 and will be removed in 4.0. Use Symfony\Component\Routing\DependencyInjection\RoutingResolverPass instead.', RoutingResolverPass::class), E_USER_DEPRECATED);

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 3, 2017

Member

you can move that line below the "use" and use BaseRoutingResolverPass::class in sprintf

This comment has been minimized.

Copy link
@chalasr

chalasr Mar 3, 2017

Author Member

Ok I wasn't sure if having it immediately after the namespace has an importance

@@ -23,6 +23,7 @@
"symfony/http-foundation": "~2.8|~3.0",
"symfony/yaml": "~2.8|~3.0",
"symfony/expression-language": "~2.8|~3.0",
"symfony/dependency-injection": "~2.7|~3.0",

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 3, 2017

Member

2.8 instead of 2.7

This comment has been minimized.

Copy link
@chalasr

chalasr Mar 3, 2017

Author Member

fixed

@chalasr chalasr force-pushed the chalasr:routingresolverpass branch from 7135861 to 7d062fb Mar 3, 2017

@nicolas-grekas
Copy link
Member

left a comment

👍

@chalasr chalasr force-pushed the chalasr:routingresolverpass branch 2 times, most recently from 7f9ce37 to 8b04332 Mar 3, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Mar 4, 2017

class RoutingResolverPass implements CompilerPassInterface
{
private $resolverServiceId = 'routing.resolver';
private $loaderTag = 'routing.loader';

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 5, 2017

Member

default values could be removed here, would prevent a duplication and any sync mistake

This comment has been minimized.

Copy link
@chalasr

chalasr Mar 5, 2017

Author Member

that's a mistake, fixed. Thanks

@chalasr chalasr force-pushed the chalasr:routingresolverpass branch from 8b04332 to 32be16b Mar 5, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 5, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 32be16b into symfony:master Mar 5, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 5, 2017

feature #21835 [FrameworkBundle][Routing] Move RoutingResolverPass to…
… the Routing component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][Routing] Move RoutingResolverPass to the Routing component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

32be16b Move RoutingResolverPass to the Routing component

@chalasr chalasr referenced this pull request Mar 6, 2017

Closed

[FrameworkBundle] Move compiler passes to their component #21284

11 of 11 tasks complete

@fabpot fabpot referenced this pull request May 1, 2017

Merged

Release v3.3.0-BETA1 #22603

@chalasr chalasr deleted the chalasr:routingresolverpass branch May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.