[HttpKernel] Allow signing URIs with a custom query string parameter #21842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures look unrelated. |
| */ | ||
| public function __construct($secret) | ||
| public function __construct($secret, $parameter = null) |
There was a problem hiding this comment.
$parameter = '_hash', instead of null?
thewilkybarkid
force-pushed
the
uri-signer-parameter
branch
from
62a834f to
32301c3
Compare
|
Can you add a note in the component CHANGELOG? |
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2017
…ring parameter (thewilkybarkid) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel] Allow signing URIs with a custom query string parameter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `UriSigner` is currently restricting to using `_hash` as the query string parameter, this makes is customisable. Commits ------- 32301c3 Allow a custom query string parameter
|
done in ae2722f |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UriSigneris currently restricting to using_hashas the query string parameter, this makes is customisable.