New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Escape exception messages in renderException #22142

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
6 participants
@chalasr
Member

chalasr commented Mar 24, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22021
License MIT
Doc PR n/a

Adding style on exception messages should be prevented, it leads to weird results.

Allowing formatting in them would be a nightmare, given that Symfony itself applies some formatting when rendering the exception.

@ro0NL

This comment has been minimized.

Show comment
Hide comment
@ro0NL

ro0NL Mar 25, 2017

Contributor

Tested it, and confirming this fixes the issue.

Status: Reviewed

Contributor

ro0NL commented Mar 25, 2017

Tested it, and confirming this fixes the issue.

Status: Reviewed

@chalasr

This comment has been minimized.

Show comment
Hide comment
@chalasr

chalasr Mar 27, 2017

Member

build failure unrelated (I'm looking at it).

Member

chalasr commented Mar 27, 2017

build failure unrelated (I'm looking at it).

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Mar 27, 2017

Member

@chalasr Looks like @nicolas-grekas is already on it #22177

Member

fabpot commented Mar 27, 2017

@chalasr Looks like @nicolas-grekas is already on it #22177

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Mar 27, 2017

Member

Thank you @chalasr.

Member

fabpot commented Mar 27, 2017

Thank you @chalasr.

@fabpot fabpot merged commit cb13482 into symfony:2.7 Mar 27, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 27, 2017

bug #22142 [Console] Escape exception messages in renderException (ch…
…alasr)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Escape exception messages in renderException

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22021
| License       | MIT
| Doc PR        | n/a

Adding style on exception messages should be prevented, it leads to weird results.

> Allowing formatting in them would be a nightmare, given that Symfony itself applies some formatting when rendering the exception.

Commits
-------

cb13482 [Console] Escape exception messages

@chalasr chalasr deleted the chalasr:escape-exceptions branch Mar 27, 2017

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Mar 27, 2017

Member

It's a king a BC break isn't ? cf #9055

Member

lyrixx commented Mar 27, 2017

It's a king a BC break isn't ? cf #9055

fabpot added a commit that referenced this pull request Mar 29, 2017

bug #22188 [Console] Revised exception rendering (ro0NL)
This PR was squashed before being merged into the 2.7 branch (closes #22188).

Discussion
----------

[Console] Revised exception rendering

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Continuation of #22142, as escaping can break too i just realized.

Before

![image](https://cloud.githubusercontent.com/assets/1047696/24376962/fc85a15c-133d-11e7-90fe-a8c754cbf592.png)

After

![image](https://cloud.githubusercontent.com/assets/1047696/24377289/340a8f2e-133f-11e7-83b3-54e1ea6f46bd.png)

cc @chalasr

Commits
-------

17f1f07 [Console] Revised exception rendering

This was referenced Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment