New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Revised exception rendering #22188

Closed
wants to merge 2 commits into
base: 2.7
from

Conversation

Projects
None yet
5 participants
@ro0NL
Contributor

ro0NL commented Mar 27, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Continuation of #22142, as escaping can break too i just realized.

Before

image

After

image

cc @chalasr

@ro0NL ro0NL changed the base branch from master to 2.7 Mar 27, 2017

@chalasr

👍 Would be nice to add a test covering the breaking case

@ro0NL

This comment has been minimized.

Show comment
Hide comment
@ro0NL

ro0NL Mar 27, 2017

Contributor

Done. Test on 2.7

-  dont break here <  
-  info>!</info>      
+  dont break here \  
+  !</info>   
Contributor

ro0NL commented Mar 27, 2017

Done. Test on 2.7

-  dont break here <  
-  info>!</info>      
+  dont break here \  
+  !</info>   

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Mar 28, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Mar 29, 2017

Member

Thank you @ro0NL.

Member

fabpot commented Mar 29, 2017

Thank you @ro0NL.

fabpot added a commit that referenced this pull request Mar 29, 2017

bug #22188 [Console] Revised exception rendering (ro0NL)
This PR was squashed before being merged into the 2.7 branch (closes #22188).

Discussion
----------

[Console] Revised exception rendering

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Continuation of #22142, as escaping can break too i just realized.

Before

![image](https://cloud.githubusercontent.com/assets/1047696/24376962/fc85a15c-133d-11e7-90fe-a8c754cbf592.png)

After

![image](https://cloud.githubusercontent.com/assets/1047696/24377289/340a8f2e-133f-11e7-83b3-54e1ea6f46bd.png)

cc @chalasr

Commits
-------

17f1f07 [Console] Revised exception rendering

@fabpot fabpot closed this Mar 29, 2017

@fabpot fabpot referenced this pull request Apr 4, 2017

Merged

Release v2.7.26 #22263

@ro0NL ro0NL deleted the ro0NL:console/exception branch Apr 4, 2017

fabpot added a commit that referenced this pull request Apr 4, 2017

minor #22270 [Console] Fix render exception test (ro0NL)
This PR was squashed before being merged into the 3.2 branch (closes #22270).

Discussion
----------

[Console] Fix render exception test

| Q             | A
| ------------- | ---
| Branch?       | 3.2 and up
| Bug fix?      | yes (regression from #22188 in master)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22217 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

As pointed out by @chalasr tests are mysteriously broken.. not sure what i missed but this is apparently needed now..

cc @fabpot

Commits
-------

6b71722 [Console] Fix render exception test

This was referenced Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment