Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebLink][TwigBundle] Fix registration of the twig extension #22639

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
4 participants
@ogizanagi
Copy link
Member

commented May 4, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets See http://symfony.com/blog/new-in-symfony-3-3-weblink-component comments
License MIT
Doc PR N/A

BTW it is the only extension not using a classic service definition and adding the tag using the Symfony\Bundle\TwigBundle\DependencyInjection\Compiler\ExtensionPass class.

(Fabbot failure fixed in #22640)

@ogizanagi ogizanagi force-pushed the ogizanagi:weblink/register_twig_ext branch from e1b6f12 to 3d8a564 May 4, 2017

@chalasr

chalasr approved these changes May 7, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented May 7, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 3d8a564 into symfony:master May 7, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request May 7, 2017

bug #22639 [WebLink][TwigBundle] Fix registration of the twig extensi…
…on (ogizanagi)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[WebLink][TwigBundle] Fix registration of the twig extension

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | See http://symfony.com/blog/new-in-symfony-3-3-weblink-component comments
| License       | MIT
| Doc PR        | N/A

BTW it is the only extension not using a classic service definition and adding the tag using the `Symfony\Bundle\TwigBundle\DependencyInjection\Compiler\ExtensionPass` class.

(Fabbot failure fixed in #22640)

Commits
-------

3d8a564 [WebLink][TwigBundle] Fix registration of the twig extension

@ogizanagi ogizanagi deleted the ogizanagi:weblink/register_twig_ext branch May 7, 2017

@fabpot fabpot referenced this pull request May 17, 2017

Merged

Release v3.3.0-RC1 #22731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.