Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice #22669

Merged

Conversation

Projects
None yet
5 participants
@ogizanagi
Copy link
Member

commented May 8, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/recipes#46
License MIT
Doc PR N/A

As spotted in symfony/recipes#46, there is no reason to call registerBundles on the kernel instance, as it's already booted. So we just have to use getBundles instead and registerBundles can be implemented in a non-rewindable way, as done with flex.

@javiereguiluz javiereguiluz added this to the 2.7 milestone May 11, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented May 11, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 040edfe into symfony:2.7 May 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 11, 2017

bug #22669 [FrameworkBundle] AbstractConfigCommand: do not try regist…
…ering bundles twice (ogizanagi)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/recipes#46
| License       | MIT
| Doc PR        | N/A

As spotted in symfony/recipes#46, there is no reason to call `registerBundles` on the kernel instance, as it's already booted. So we just have to use `getBundles` instead and `registerBundles` can be implemented in a non-rewindable way, as done with flex.

Commits
-------

040edfe [FrameworkBundle] AbstractConfigCommand: do not try registering bundles twice

@ogizanagi ogizanagi deleted the ogizanagi:fix/2.7/fwb/asbtract_config_cmd_get_bundles branch May 11, 2017

@fabpot fabpot referenced this pull request May 17, 2017

Merged

Release v3.3.0-RC1 #22731

This was referenced May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.