New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fixed different behaviour of key and value user inputs in multiple choice question #22718

Closed
wants to merge 2 commits into
base: 2.7
from

Conversation

Projects
None yet
7 participants
@borNfreee
Contributor

borNfreee commented May 15, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22706
License MIT
Doc PR -

Fixed a bug when value from multiple choice list could not be selected by user's input
while it could be selected by typing its index in the list.

[Console] Fixed different behaviour of key and value user inputs in c…
…ase of special character in multiple ChoiceQuestion

Fixed a bug when value from multiple choice list could not be selected by user's input
while it could be selected by typing its index in the list.

@borNfreee borNfreee changed the title from [Console] Fixed different behaviour of key and value user inputs in c… to [Console] Fixed different behaviour of key and value user inputs in multiple choice question May 15, 2017

@ro0NL

ro0NL approved these changes May 16, 2017

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone May 18, 2017

@xabbuh

xabbuh approved these changes May 27, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 27, 2017

Member

Thank you @borNfreee.

Member

fabpot commented May 27, 2017

Thank you @borNfreee.

fabpot added a commit that referenced this pull request May 27, 2017

bug #22718 [Console] Fixed different behaviour of key and value user …
…inputs in multiple choice question (borNfreee)

This PR was squashed before being merged into the 2.7 branch (closes #22718).

Discussion
----------

[Console] Fixed different behaviour of key and value user inputs in multiple choice question

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22706
| License       | MIT
| Doc PR        | -

Fixed a bug when value from multiple choice list could not be selected by user's input
while it could be selected by typing its index in the list.

Commits
-------

2861bd7 [Console] Fixed different behaviour of key and value user inputs in multiple choice question

@fabpot fabpot closed this May 27, 2017

@borNfreee borNfreee deleted the borNfreee:ticket_22706 branch May 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment