[MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows #22787

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
@ChadSikorra
Contributor

ChadSikorra commented May 19, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? -
Fixed tickets #22712
License MIT

This resolves the issue discussed in #22712. This works on both Windows and Linux. Specifically it removes the additional hanging that was caused on Windows when attempting to write/close a TCP socket that's not open on the other end in asynchronous mode.

@ChadSikorra ChadSikorra changed the title from Avoid timeouts when sending server log data via TCP. to Fix the Monlog ServerLogHandler from Hanging on Windows May 19, 2017

@ChadSikorra ChadSikorra changed the title from Fix the Monlog ServerLogHandler from Hanging on Windows to [MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows May 19, 2017

@xabbuh xabbuh added this to the 3.3 milestone May 20, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 20, 2017

Member

Thank you @ChadSikorra.

Member

fabpot commented May 20, 2017

Thank you @ChadSikorra.

fabpot added a commit that referenced this pull request May 20, 2017

bug #22787 [MonologBridge] Fix the Monlog ServerLogHandler from Hangi…
…ng on Windows (ChadSikorra)

This PR was squashed before being merged into the 3.3 branch (closes #22787).

Discussion
----------

[MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | -
| Fixed tickets | #22712
| License       | MIT

This resolves the issue discussed in #22712. This works on both Windows and Linux. Specifically it removes the additional hanging that was caused on Windows when attempting to write/close a TCP socket that's not open on the other end in asynchronous mode.

Commits
-------

be60aa4 [MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment