New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] fix colon without space deprecation #22829

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
4 participants
@xabbuh
Member

xabbuh commented May 21, 2017

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

A colon after a mapping key that is not followed by a space is valid if the mapping key is quoted.

[Yaml] fix colon without space deprecation
A colon after a mapping key that is not followed by a space is valid if
the mapping key is quoted.
@nicolas-grekas

👍

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 25, 2017

Member

Thank you @xabbuh.

Member

fabpot commented May 25, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 57f6941 into symfony:3.2 May 25, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 25, 2017

bug #22829 [Yaml] fix colon without space deprecation (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] fix colon without space deprecation

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

A colon after a mapping key that is not followed by a space is valid if the mapping key is quoted.

Commits
-------

57f6941 [Yaml] fix colon without space deprecation

@xabbuh xabbuh deleted the xabbuh:pr-19504 branch May 26, 2017

This was referenced May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment