New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] fix multiline block handling #22853

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
4 participants
@xabbuh
Member

xabbuh commented May 22, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21114, #22105 (comment)
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.3 milestone May 22, 2017

Show outdated Hide outdated src/Symfony/Component/Yaml/Parser.php
@@ -368,7 +368,11 @@ private function doParse($value, $flags)
foreach ($this->lines as $line) {
try {
$parsedLine = Inline::parse($line, $flags, $this->refs);
if (isset($line[0]) && in_array($line[0], array('"', "'"), true)) {

This comment has been minimized.

@nicolas-grekas

nicolas-grekas May 23, 2017

Member

shorter and easier to read imho:
if (isset($line[0]) && ('"' === $line[0] || "'" === $line[0])) {

@nicolas-grekas

nicolas-grekas May 23, 2017

Member

shorter and easier to read imho:
if (isset($line[0]) && ('"' === $line[0] || "'" === $line[0])) {

@nicolas-grekas

👍 with minor comment

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 24, 2017

Member

Thank you @xabbuh.

Member

fabpot commented May 24, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit a2079d6 into symfony:3.3 May 24, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 24, 2017

bug #22853 [Yaml] fix multiline block handling (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] fix multiline block handling

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21114, #22105 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

a2079d6 [Yaml] fix multiline block handling

@xabbuh xabbuh deleted the xabbuh:pr-21114 branch May 24, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment