New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Handle project dir in cache:clear command #22872

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented May 23, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22721
License MIT
Doc PR -
@chalasr

This comment has been minimized.

Show comment
Hide comment
@chalasr

chalasr May 23, 2017

Member

It fixes it 👍
Status: reviewed

Member

chalasr commented May 23, 2017

It fixes it 👍
Status: reviewed

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 23, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented May 23, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit fadffad into symfony:3.3 May 23, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 23, 2017

bug #22872 [FrameworkBundle] Handle project dir in cache:clear comman…
…d (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Handle project dir in cache:clear command

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22721
| License       | MIT
| Doc PR        | -

Commits
-------

fadffad [FrameworkBundle] Handle project dir in cache:clear command

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-warmup branch May 24, 2017

fabpot added a commit that referenced this pull request May 26, 2017

bug #22921 [FrameworkBundle] Only override getProjectDir if it exists…
… in the kernel (aschempp)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Only override getProjectDir if it exists in the kernel

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22872, #2289
| License       | MIT
| Doc PR        | -

As discussed with @nicolas-grekas, the `getProjectDir` method does not belong to `KernelInterface` so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.

Commits
-------

c7ed08e Only override getProjectDir if it exists in the kernel

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment