[HttpKernel] Add ability to configure catching exceptions for Client #22890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
new features should be submitted against 3.4 |
xabbuh
reviewed
May 29, 2017
| @@ -31,6 +31,7 @@ | |||
| class Client extends BaseClient | |||
| { | |||
| protected $kernel; | |||
| protected $catchExceptions = true; | |||
xabbuh
reviewed
May 29, 2017
| * | ||
| * @param bool $catchExceptions Whether to catch exceptions | ||
| */ | ||
| public function catchExceptions($catchExceptions = true) |
There was a problem hiding this comment.
having a default value here does not very useful to me
|
Anything preventing this from making it into 3.4? |
nicolas-grekas
approved these changes
Sep 26, 2017
ogizanagi
approved these changes
Sep 26, 2017
| * | ||
| * @return bool | ||
| */ | ||
| public function isCatchingExceptions() |
There was a problem hiding this comment.
Is this method really useful?
There was a problem hiding this comment.
Not really, I was just matching Symfony\Component\BrowserKit\Client::isFollowingRedirects()
|
I added a Let me know if you want me to remove |
|
Thank you @kbond. |
ogizanagi
added a commit
that referenced
this pull request
Sep 26, 2017
…ons for Client (kbond) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Add ability to configure catching exceptions for Client | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | todo Debugging exceptions in functional tests is difficult as you need to look at the logs to see which exception was thrown. Disabling catching of exceptions in the client would allow the exception to bubble up to phpunit and make it easier to see what exception was thrown. Commits ------- 4812e60 add ability to configure catching exceptions
This was referenced Oct 18, 2017
Merged
Merged
robfrawley
added a commit
to robfrawley/liip-imagine-bundle
that referenced
this pull request
May 7, 2018
…anged browser kit client to not catch exceptions to fix our test suite. References: - https://symfony.com/blog/new-in-symfony-4-1-deprecated-the-bundle-notation - symfony/symfony#26085 - symfony/symfony#22890 Signed-off-by: Rob Frawley 2nd <rmf@src.run>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging exceptions in functional tests is difficult as you need to look at the logs to see which exception was thrown. Disabling catching of exceptions in the client would allow the exception to bubble up to phpunit and make it easier to see what exception was thrown.