New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProxyManager] Add FC layer #22892

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented May 24, 2017

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? yes - minor
Deprecations? yes - made a class final
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This makes PRoxyDumper compatible with DumperInterface v4.0.
Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.

@@ -82,6 +82,8 @@ DependencyInjection
* Autowiring services based on the types they implement is deprecated and won't be supported in version 4.0. Rename (or alias) your services to their FQCN id to make them autowirable.
* [BC BREAK] The `NullDumper` class has been made final

This comment has been minimized.

@stof

stof May 24, 2017

Member

this looks wrong to me. It is not actually final in 3.3

@stof

stof May 24, 2017

Member

this looks wrong to me. It is not actually final in 3.3

This comment has been minimized.

@nicolas-grekas

nicolas-grekas May 24, 2017

Member

@final + the BC break means to me that we're considering the class final for real, taking advantage of it. IMHO, it sends the good info to the reader.

@nicolas-grekas

nicolas-grekas May 24, 2017

Member

@final + the BC break means to me that we're considering the class final for real, taking advantage of it. IMHO, it sends the good info to the reader.

@nicolas-grekas nicolas-grekas merged commit 4aeb6d8 into symfony:3.3 May 25, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 25, 2017

feature #22892 [ProxyManager] Add FC layer (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[ProxyManager] Add FC layer

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes - minor
| Deprecations? | yes - made a class final
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This makes PRoxyDumper compatible with DumperInterface v4.0.
Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.

Commits
-------

4aeb6d8 [ProxyManager] Add FC layer

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-proxym branch May 25, 2017

nicolas-grekas added a commit that referenced this pull request May 25, 2017

minor #22891 [travis] Fix 3/4 cross tests (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[travis] Fix 3/4 cross tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | needs #22892
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I just realized that using 7.0 to run deps=high test prevents loading 4.0 versions of deps.

Commits
-------

6311be7 [travis] Fix 3/4 cross tests

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment