New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing abstract key in XmlDumper #22901

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
5 participants
@weaverryan
Member

weaverryan commented May 25, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR n/a

Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using debug:container some_abstract_service and was seeing "no" for abstract.

When this merges to 3.3, the services-abstract.xml will need to change to this:

<?xml version="1.0" encoding="utf-8"?>
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
  <services>
    <service id="service_container" class="Symfony\Component\DependencyInjection\ContainerInterface" synthetic="true"/>
    <service id="foo" class="Foo" abstract="true"/>
    <service id="Psr\Container\ContainerInterface" alias="service_container" public="false"/>
    <service id="Symfony\Component\DependencyInjection\ContainerInterface" alias="service_container" public="false"/>
  </services>
</container>

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone May 25, 2017

@nicolas-grekas

👍

@xabbuh

xabbuh approved these changes May 25, 2017

👍 (I don't like the services<number> naming, but the change itself looks good)

@weaverryan

This comment has been minimized.

Show comment
Hide comment
@weaverryan

weaverryan May 25, 2017

Member

@xabbuh yea, me either :). I've renamed it!

Member

weaverryan commented May 25, 2017

@xabbuh yea, me either :). I've renamed it!

Fixing missing abstract attribute in XmlDumper
Caused mis-reporting of abstract key (always no) in debug:container
@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 25, 2017

Member

Thank you @weaverryan.

Member

fabpot commented May 25, 2017

Thank you @weaverryan.

@fabpot fabpot merged commit 40f60ec into symfony:2.7 May 25, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 25, 2017

bug #22901 Fix missing abstract key in XmlDumper (weaverryan)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix missing abstract key in XmlDumper

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using `debug:container some_abstract_service` and was seeing "no" for abstract.

When this merges to 3.3, the `services-abstract.xml` will need to change to this:

```xml
<?xml version="1.0" encoding="utf-8"?>
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
  <services>
    <service id="service_container" class="Symfony\Component\DependencyInjection\ContainerInterface" synthetic="true"/>
    <service id="foo" class="Foo" abstract="true"/>
    <service id="Psr\Container\ContainerInterface" alias="service_container" public="false"/>
    <service id="Symfony\Component\DependencyInjection\ContainerInterface" alias="service_container" public="false"/>
  </services>
</container>
```

Commits
-------

40f60ec Fixing missing abstract attribute in XmlDumper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment