New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const #22904

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented May 25, 2017

Q A
Branch? 3.3
Bug fix? yes (a missing part of a 3.3 feat.)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

See symfony/symfony-docs#7045

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 25, 2017

Member

Can we ignore fabbot report here? Alignment is desired to me...

Member

nicolas-grekas commented May 25, 2017

Can we ignore fabbot report here? Alignment is desired to me...

@xabbuh

xabbuh approved these changes May 25, 2017

If we prefer to use the binary format, I am in favour of keep the alignment to ease readability.

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz May 25, 2017

Member

I don't think we should keep the alignment. If we apply some code formatting syntax, we should apply it always and without exceptions. Otherwise this will cause problems when running the php-cs-fixer in the entire codebase, which is done from time to time.

Member

javiereguiluz commented May 25, 2017

I don't think we should keep the alignment. If we apply some code formatting syntax, we should apply it always and without exceptions. Otherwise this will cause problems when running the php-cs-fixer in the entire codebase, which is done from time to time.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 25, 2017

Member

ok, fabbot green

Member

nicolas-grekas commented May 25, 2017

ok, fabbot green

@nicolas-grekas nicolas-grekas changed the title from [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS const to [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const May 25, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 25, 2017

Member

Just renamed the const to be even more explicit: Request::HEADER_X_FORWARDED_AWS_ELB

Member

nicolas-grekas commented May 25, 2017

Just renamed the const to be even more explicit: Request::HEADER_X_FORWARDED_AWS_ELB

@weaverryan

This comment has been minimized.

Show comment
Hide comment
@weaverryan

weaverryan May 25, 2017

Member

👍 This will help the docs - it's already complex enough :)

Member

weaverryan commented May 25, 2017

👍 This will help the docs - it's already complex enough :)

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 25, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented May 25, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 9ba12b0 into symfony:3.3 May 25, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 25, 2017

feature #22904 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_E…
…LB const (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes (a missing part of a 3.3 feat.)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See symfony/symfony-docs#7045

Commits
-------

9ba12b0 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:req-x branch May 29, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment