New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Only override getProjectDir if it exists in the kernel #22921

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
6 participants
@aschempp
Contributor

aschempp commented May 26, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22872, #2289
License MIT
Doc PR -

As discussed with @nicolas-grekas, the getProjectDir method does not belong to KernelInterface so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.

@nicolas-grekas

👍 but for 3.3

@aschempp aschempp changed the base branch from 3.4 to 3.3 May 26, 2017

@aschempp

This comment has been minimized.

Show comment
Hide comment
@aschempp

aschempp May 26, 2017

Contributor

sorry about that, I have rebased to 3.3

Contributor

aschempp commented May 26, 2017

sorry about that, I have rebased to 3.3

@stof

stof approved these changes May 26, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 26, 2017

Member

Thank you @aschempp.

Member

fabpot commented May 26, 2017

Thank you @aschempp.

@fabpot fabpot merged commit c7ed08e into symfony:3.3 May 26, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request May 26, 2017

bug #22921 [FrameworkBundle] Only override getProjectDir if it exists…
… in the kernel (aschempp)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Only override getProjectDir if it exists in the kernel

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22872, #2289
| License       | MIT
| Doc PR        | -

As discussed with @nicolas-grekas, the `getProjectDir` method does not belong to `KernelInterface` so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.

Commits
-------

c7ed08e Only override getProjectDir if it exists in the kernel

@xabbuh xabbuh added this to the 3.3 milestone May 26, 2017

@aschempp aschempp deleted the aschempp:optional-projectdir branch May 29, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment