New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check #22930

Merged
merged 1 commit into from May 28, 2017

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Member

nicolas-grekas commented May 28, 2017

This reverts commit cfb090d, reversing
changes made to 4e8f403.

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

PR #22925 made the bridge fail with:

Fatal error: Declaration of Symfony\Bridge\PhpUnit\SymfonyTestsListener::addSkippedTest() must be compatible with that of PHPUnit_Framework_TestListener::addSkippedTest() in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 32

See https://travis-ci.org/symfony/symfony/builds/236863221 on 3.3
and https://travis-ci.org/symfony/symfony/builds/236863238 on 3.4

Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check t…
…o also check for namespaced class (GawainLynch)"

This reverts commit cfb090d, reversing
changes made to 4e8f403.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone May 28, 2017

@nicolas-grekas nicolas-grekas merged commit 934c0c0 into symfony:3.3 May 28, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 28, 2017

bug #22930 Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_al…
…ias check (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check

This reverts commit cfb090d, reversing
changes made to 4e8f403.

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

PR #22925 made the bridge fail with:
> Fatal error: Declaration of Symfony\Bridge\PhpUnit\SymfonyTestsListener::addSkippedTest() must be compatible with that of PHPUnit_Framework_TestListener::addSkippedTest() in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 32

See https://travis-ci.org/symfony/symfony/builds/236863221 on 3.3
and https://travis-ci.org/symfony/symfony/builds/236863238 on 3.4

Commits
-------

934c0c0 Revert "bug #22925 [PhpUnitBridge] Adjust PHPUnit class_alias check to also check for namespaced class (GawainLynch)"

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:revert-phpunit branch May 28, 2017

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment