New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Fallback to regular import when glob fails #22940

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented May 29, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22938
License MIT
Doc PR -

Fixes a BC break as reported in linked issue.

} else {
foreach ($this->glob($resource, false, $_, $ignoreErrors) as $path => $info) {
++$ct;
if (is_string($resource) && false !== strpbrk($resource, '*?{[')) {

This comment has been minimized.

@ro0NL

ro0NL May 29, 2017

Contributor

(...) || $type === 'glob' right?

@ro0NL

ro0NL May 29, 2017

Contributor

(...) || $type === 'glob' right?

This comment has been minimized.

@nicolas-grekas

nicolas-grekas May 29, 2017

Member

not sure it would change anything, so not to me

@nicolas-grekas

nicolas-grekas May 29, 2017

Member

not sure it would change anything, so not to me

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 29, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented May 29, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 29802a2 into symfony:master May 29, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 29, 2017

bug #22940 [Config] Fallback to regular import when glob fails (nicol…
…as-grekas)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[Config] Fallback to regular import when glob fails

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22938
| License       | MIT
| Doc PR        | -

Fixes a BC break as reported in linked issue.

Commits
-------

29802a2 [Config] Fallback to regular import when glob fails
@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot May 29, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented May 29, 2017

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request May 29, 2017

bug #22940 [Config] Fallback to regular import when glob fails (nicol…
…as-grekas)

This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #22940).

Discussion
----------

[Config] Fallback to regular import when glob fails

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22938
| License       | MIT
| Doc PR        | -

Fixes a BC break as reported in linked issue.

Commits
-------

7b4066e [Config] Fallback to regular import when glob fails

@fabpot fabpot referenced this pull request May 29, 2017

Merged

Release v3.3.0 #22949

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 May 29, 2017

Contributor

This has broken my app while upgrading from 3.3.0-RC1 to 3.3.0. 😞

Symfony\Component\Config\Exception\FileLoaderLoadException:
Cannot load resource "[...]/etc/routing.{php,yaml}"

Kernel::configureRoutes() +- same as in the Flex recipe, etc/routing.yaml doesn't exist.

Contributor

Majkl578 commented May 29, 2017

This has broken my app while upgrading from 3.3.0-RC1 to 3.3.0. 😞

Symfony\Component\Config\Exception\FileLoaderLoadException:
Cannot load resource "[...]/etc/routing.{php,yaml}"

Kernel::configureRoutes() +- same as in the Flex recipe, etc/routing.yaml doesn't exist.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas May 29, 2017

Member

Please open an issue with a description of the conditions + reproducer if possible

Member

nicolas-grekas commented May 29, 2017

Please open an issue with a description of the conditions + reproducer if possible

@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 May 29, 2017

Contributor

Here you go: #22950

Contributor

Majkl578 commented May 29, 2017

Here you go: #22950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment