New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Allow micro kernel to subscribe events easily #23812

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
5 participants
@ogizanagi
Member

ogizanagi commented Aug 6, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16982
License MIT
Doc PR N/A

just by implementing EventSubscriberInterface. See related issue for other implementation suggestions.

@dunglas

dunglas approved these changes Aug 7, 2017

@fabpot

fabpot approved these changes Aug 9, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Aug 9, 2017

Member

Thank you @ogizanagi.

Member

fabpot commented Aug 9, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit b31542e into symfony:3.4 Aug 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Aug 9, 2017

feature #23812 [FrameworkBundle] Allow micro kernel to subscribe even…
…ts easily (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Allow micro kernel to subscribe events easily

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #16982 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

just by implementing `EventSubscriberInterface`. See related issue for other implementation suggestions.

Commits
-------

b31542e [FrameworkBundle] Allow micro kernel to subscribe events easily
@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Aug 9, 2017

Member

added a note in the CHANGELOG in 6727d41

Member

fabpot commented Aug 9, 2017

added a note in the CHANGELOG in 6727d41

@ogizanagi ogizanagi deleted the ogizanagi:feature/fwb/event_subscriber_micro_kernel branch Aug 9, 2017

nicolas-grekas added a commit that referenced this pull request Sep 20, 2017

feature #24257 [HttpKernel][DI] Enable Kernel to implement CompilerPa…
…ssInterface (nicolas-grekas)

This PR was squashed before being merged into the 3.4 branch (closes #24257).

Discussion
----------

[HttpKernel][DI] Enable Kernel to implement CompilerPassInterface

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

In the same spirit as #13761 that allowed DI exts to be also compiler passes, and as #23812 that allowed the kernel to listen to events, in our new bundle-less world, should we allow the kernel to register itself as a compiler pass? That would make some scenario possible (like having a `TestKernel` that turns some services public.)

Commits
-------

6973a1a [HttpKernel][DI] Enable Kernel to implement CompilerPassInterface

This was referenced Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment