New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering empty uuids in ORMQueryBuilderLoader. #23853

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
6 participants
@mlazovla
Contributor

mlazovla commented Aug 10, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23808
License MIT
Doc PR no

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Aug 12, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
Member

nicolas-grekas commented Aug 12, 2017

@Tobion

This comment has been minimized.

Show comment
Hide comment
@Tobion

Tobion Aug 12, 2017

Member

Seems good enough. But #23808 (comment) would be the more correct solution.

Member

Tobion commented Aug 12, 2017

Seems good enough. But #23808 (comment) would be the more correct solution.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Aug 15, 2017

Member

@mlazovla what's your stand about that "more correct solution"?

Member

nicolas-grekas commented Aug 15, 2017

@mlazovla what's your stand about that "more correct solution"?

@mlazovla

This comment has been minimized.

Show comment
Hide comment
@mlazovla

mlazovla Aug 15, 2017

Contributor

Maryo's new solution looks more universal than my PR. But I am not sure if it broke some edge case.

Contributor

mlazovla commented Aug 15, 2017

Maryo's new solution looks more universal than my PR. But I am not sure if it broke some edge case.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Aug 25, 2017

Member

So, should we merge and later on do what @maryo describes? Anyone willing to give it a try?

Member

nicolas-grekas commented Aug 25, 2017

So, should we merge and later on do what @maryo describes? Anyone willing to give it a try?

@javiereguiluz

This definitely improves our current code and it looks correct. I'm not sure about the other proposed solution here and even its author mentions some potential problems with PostgreSQL.

@fabpot

fabpot approved these changes Sep 11, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 11, 2017

Member

Thank you @mlazovla.

Member

fabpot commented Sep 11, 2017

Thank you @mlazovla.

@fabpot fabpot merged commit 27e8cd2 into symfony:2.7 Sep 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 11, 2017

bug #23853 Filtering empty uuids in ORMQueryBuilderLoader. (mlazovla)
This PR was merged into the 2.7 branch.

Discussion
----------

Filtering empty uuids in ORMQueryBuilderLoader.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23808
| License       | MIT
| Doc PR        | no

Commits
-------

27e8cd2 Filtering empty uuids in ORMQueryBuilderLoader.

@fabpot fabpot referenced this pull request Sep 11, 2017

Merged

Release v3.3.9 #24156

This was referenced Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment