[VarDumper] play nice with open_basedir when looking for composer.json #23878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
linkstub-open_basedir
branch
from
f86dafa
to
1bea774
Compare
|
From what I see, it should work, I need to test it in the original context I got the error, I can only do that at work so I'll give you a straight answer within the next week. As a side note I'm afraid this will truncate reported file names, am I wrong ? Isn't there a more straight method to determine the project root ? Something from configuration or a constant or anything else would be great actually. |
|
This is pure visual truncation so we don't really care if it's not perfect. |
|
Seems legit, I will test it as soon as I can, thanks for patching so fast. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 16, 2017
…omposer.json (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [VarDumper] play nice with open_basedir when looking for composer.json | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23661 | License | MIT | Doc PR | - ping @pounard, can you please confirm this fixes the issue you reported? Commits ------- 1bea774 [VarDumper] play nice with open_basedir when looking for composer.json
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @pounard, can you please confirm this fixes the issue you reported?