Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added support for guards when advancing workflow from a command #23906
@nicolas-grekas you can simply add the workflow label instead of pinging me ;) (Both are fine anyway)
I understand your PR it's a convenient fallback but IMHO it will lead to many WTF for people that are not aware to see "feature"/fallaback.
May be we can instead throw an exception if the token is null. WDYT?
@lyrixx Hrmm, that makes sense.
In my own implementation, I'm only writing expressions that check the subject. It would be nice if we could only throw an exception only if the expression required the user (like it used an is_granted check), but that would mean modifying the Expression language, right?