New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and fix for issue in array model data in EntityType field with multiple=true #23980

Closed
wants to merge 4 commits into
base: 2.7
from

Conversation

Projects
None yet
5 participants
@stoccc
Contributor

stoccc commented Aug 25, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT
Fixed tickets #23927

Provided some tests and the fix for #23927.
Rebased to 2.7, replaces #23930

stoccc added some commits Aug 25, 2017

added tests
Added tests for #23927
fix code style
fix code style
@yceruto

This comment has been minimized.

Show comment
Hide comment
@yceruto

yceruto Aug 25, 2017

Contributor

#23927 (comment)
It seems that in php 5.3 tests pass, while in php 7 and 7.1 they don't pass. I can't figure out why. In my installation with 2.8 on php 7.0.10 I don't have problems. :(

PHP: 7 deps=high failure is normal, because was Installed symfony/form (2.8.x-dev 41d84cd) and your changes aren't there yet. (nothing to do).

PHP: 7.1 deps=low failure is understood, because was installed symfony/form (v2.7.25) (release) and your changes aren't there either, but you need update deps=low constraint in Bridge/Doctrine/composer.json for "symfony/form" to be able to test these changes.


Please add the "Fixed tickets" row to the QA table, it is helpful to close the related issue automatically when this PR is merged.

Q A
Fixed tickets #23927
Contributor

yceruto commented Aug 25, 2017

#23927 (comment)
It seems that in php 5.3 tests pass, while in php 7 and 7.1 they don't pass. I can't figure out why. In my installation with 2.8 on php 7.0.10 I don't have problems. :(

PHP: 7 deps=high failure is normal, because was Installed symfony/form (2.8.x-dev 41d84cd) and your changes aren't there yet. (nothing to do).

PHP: 7.1 deps=low failure is understood, because was installed symfony/form (v2.7.25) (release) and your changes aren't there either, but you need update deps=low constraint in Bridge/Doctrine/composer.json for "symfony/form" to be able to test these changes.


Please add the "Fixed tickets" row to the QA table, it is helpful to close the related issue automatically when this PR is merged.

Q A
Fixed tickets #23927

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Aug 28, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Aug 28, 2017

Member

Here is the missing patch @yceruto is talking about.
Would it be possible to have a test in the Form component also?

--- a/src/Symfony/Bridge/Doctrine/composer.json
+++ b/src/Symfony/Bridge/Doctrine/composer.json
@@ -22,7 +22,7 @@
     "require-dev": {
         "symfony/stopwatch": "~2.2",
         "symfony/dependency-injection": "~2.2",
-        "symfony/form": "~2.7.25|^2.8.18",
+        "symfony/form": "~2.7.34|^2.8.27",
         "symfony/http-kernel": "~2.2",
         "symfony/property-access": "~2.3",
         "symfony/security": "~2.2",
Member

nicolas-grekas commented Aug 28, 2017

Here is the missing patch @yceruto is talking about.
Would it be possible to have a test in the Form component also?

--- a/src/Symfony/Bridge/Doctrine/composer.json
+++ b/src/Symfony/Bridge/Doctrine/composer.json
@@ -22,7 +22,7 @@
     "require-dev": {
         "symfony/stopwatch": "~2.2",
         "symfony/dependency-injection": "~2.2",
-        "symfony/form": "~2.7.25|^2.8.18",
+        "symfony/form": "~2.7.34|^2.8.27",
         "symfony/http-kernel": "~2.2",
         "symfony/property-access": "~2.3",
         "symfony/security": "~2.2",
@fabpot

fabpot approved these changes Oct 1, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Oct 1, 2017

Member

Thank you @stoccc.

Member

fabpot commented Oct 1, 2017

Thank you @stoccc.

fabpot added a commit that referenced this pull request Oct 1, 2017

bug #23980 Tests and fix for issue in array model data in EntityType …
…field with multiple=true (stoccc)

This PR was squashed before being merged into the 2.7 branch (closes #23980).

Discussion
----------

Tests and fix for issue in array model data in EntityType field with multiple=true

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| License       | MIT
| Fixed tickets | #23927

Provided some tests and the fix for #23927.
Rebased to 2.7, replaces #23930

Commits
-------

aaba6b4 Tests and fix for issue in array model data in EntityType field with multiple=true

@fabpot fabpot closed this Oct 1, 2017

This was referenced Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment