New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Add support to environment variables APP_ENV/DEBUG in KernelTestCase #24177

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@yceruto
Contributor

yceruto commented Sep 12, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets symfony/recipes#170 (comment)
License MIT
Doc PR -

/cc @fabpot

@yceruto yceruto changed the base branch from master to 3.4 Sep 12, 2017

@yceruto

This comment has been minimized.

Show comment
Hide comment
@yceruto

yceruto Sep 12, 2017

Contributor

I guess fabbot failure (unrelated) should be fixed from 2.7

Contributor

yceruto commented Sep 12, 2017

I guess fabbot failure (unrelated) should be fixed from 2.7

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Sep 12, 2017

Member

Should we merge this one as a bugfix into the 3.3 branch instead?

Member

xabbuh commented Sep 12, 2017

Should we merge this one as a bugfix into the 3.3 branch instead?

@yceruto

This comment has been minimized.

Show comment
Hide comment
@yceruto

yceruto Sep 12, 2017

Contributor

As a bugfix should be into 2.7, no? Let's me know the final decision. I'm for a bugfix rather than a feature ( similar to #24115)

Contributor

yceruto commented Sep 12, 2017

As a bugfix should be into 2.7, no? Let's me know the final decision. I'm for a bugfix rather than a feature ( similar to #24115)

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 12, 2017

Member

As env vars are "officially" supported since 3.3, I'd vote for a merge in 3.3

Member

fabpot commented Sep 12, 2017

As env vars are "officially" supported since 3.3, I'd vote for a merge in 3.3

@fabpot

fabpot approved these changes Sep 12, 2017

@yceruto yceruto changed the base branch from 3.4 to 3.3 Sep 12, 2017

@yceruto

This comment has been minimized.

Show comment
Hide comment
@yceruto

yceruto Sep 12, 2017

Contributor

Done.

Contributor

yceruto commented Sep 12, 2017

Done.

@xabbuh

xabbuh approved these changes Sep 13, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Sep 13, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented Sep 13, 2017

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 8d56744 into symfony:3.3 Sep 13, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Sep 13, 2017

bug #24177 [FrameworkBundle] Add support to environment variables APP…
…_ENV/DEBUG in KernelTestCase (yceruto)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Add support to environment variables APP_ENV/DEBUG in KernelTestCase

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/recipes#170 (comment)
| License       | MIT
| Doc PR        | -

/cc @fabpot

Commits
-------

8d56744 Add support to environment variables APP_ENV/DEBUG in KernelTestCase

@yceruto yceruto deleted the yceruto:test_env_vars branch Sep 13, 2017

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment