New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix non-instantiables auto-discovery #24199

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Sep 14, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24195
License MIT
Doc PR -
@xabbuh

xabbuh approved these changes Sep 15, 2017

@nicolas-grekas nicolas-grekas merged commit 8b7c7c1 into symfony:3.3 Sep 15, 2017

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Sep 15, 2017

bug #24199 [DI] Fix non-instantiables auto-discovery (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Fix non-instantiables auto-discovery

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24195
| License       | MIT
| Doc PR        | -

Commits
-------

8b7c7c1 [DI] Fix non-instantiables auto-discovery
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Sep 19, 2017

Member

you should probably add a test covering #24195 to prevent regressions

Member

stof commented Sep 19, 2017

you should probably add a test covering #24195 to prevent regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment