New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Preserving line breaks between sentences according to the exception message #24219

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
6 participants
@yceruto
Contributor

yceruto commented Sep 15, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24212
License MIT
Doc PR -
@ro0NL

ro0NL approved these changes Sep 15, 2017

👍 for preserving lines. Think intention was pure for cosmetic reasons.

@@ -1133,9 +1133,8 @@ private function splitStringByWidth($string, $width)
$lines[] = str_pad($line, $width);
$line = $char;
}
if ('' !== $line) {

This comment has been minimized.

@ro0NL

ro0NL Sep 15, 2017

Contributor

@yceruto i think this is trimming related in fact :)

throw new \Exception("\n\nline 1 with extra spaces        \nline 2\n\nline 4\n");

Before/After
image

image

So here's a better test ;-)

@ro0NL

ro0NL Sep 15, 2017

Contributor

@yceruto i think this is trimming related in fact :)

throw new \Exception("\n\nline 1 with extra spaces        \nline 2\n\nline 4\n");

Before/After
image

image

So here's a better test ;-)

This comment has been minimized.

@yceruto

yceruto Sep 15, 2017

Contributor

Done.

@yceruto

yceruto Sep 15, 2017

Contributor

Done.

@yceruto yceruto changed the title from [Console] Render all line breaks according to the exception message to [Console] Preserving line breaks between sentences according to the exception message Sep 15, 2017

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Sep 16, 2017

@chalasr

This comment has been minimized.

Show comment
Hide comment
@chalasr

chalasr Sep 20, 2017

Member

Thanks for fixing this bug Yonel.

Member

chalasr commented Sep 20, 2017

Thanks for fixing this bug Yonel.

@chalasr chalasr merged commit e2d4904 into symfony:2.7 Sep 20, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request Sep 20, 2017

bug #24219 [Console] Preserving line breaks between sentences accordi…
…ng to the exception message (yceruto)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Preserving line breaks between sentences according to the exception message

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24212
| License       | MIT
| Doc PR        | -

Commits
-------

e2d4904 Render all line breaks according to the exception message

@yceruto yceruto deleted the yceruto:console_error_linebreak branch Sep 20, 2017

This was referenced Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment