New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix decorated service merge in ResolveInstanceofConditionalsPass #24234

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Projects
None yet
5 participants
@dunglas
Member

dunglas commented Sep 16, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets api-platform/api-platform#414, symfony/symfony#24229
License MIT
Doc PR n/a

Follows #24229. It's the patch proposed by @nicolas-grekas + a test.

@dunglas dunglas requested review from weaverryan and nicolas-grekas Sep 16, 2017

@dunglas dunglas changed the base branch from master to 3.3 Sep 16, 2017

@dunglas dunglas referenced this pull request Sep 16, 2017

Closed

[DependencyInjection] Don't autoconfigure decorators #24229

0 of 1 task complete

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Sep 16, 2017

@fabpot

fabpot approved these changes Sep 17, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 17, 2017

Member

Thank you @dunglas.

Member

fabpot commented Sep 17, 2017

Thank you @dunglas.

@fabpot fabpot merged commit 2a30908 into symfony:3.3 Sep 17, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 17, 2017

bug #24234 [DI] Fix decorated service merge in ResolveInstanceofCondi…
…tionalsPass (dunglas)

This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Fix decorated service merge in ResolveInstanceofConditionalsPass

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | api-platform/api-platform#414, symfony/symfony#24229
| License       | MIT
| Doc PR        | n/a

Follows #24229. It's [the patch](#24229 (comment)) proposed by @nicolas-grekas + a test.

Commits
-------

2a30908 [DI] Fix decorated service merge in ResolveInstanceofConditionalsPass

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment