New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyAccess] Set a NullLogger in ApcuAdapter when Apcu is disabled in CLI #24251

Merged
merged 1 commit into from Sep 26, 2017

Conversation

Projects
None yet
5 participants
@iamluc
Contributor

iamluc commented Sep 19, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Same check as in https://github.com/symfony/symfony/pull/23390/files#diff-a5185cd58702e8e073786794a423cb27R112

@nicolas-grekas nicolas-grekas changed the base branch from 3.2 to 3.3 Sep 19, 2017

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Sep 19, 2017

@xabbuh

xabbuh approved these changes Sep 19, 2017

@stof

stof approved these changes Sep 25, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Sep 26, 2017

Member

Thank you @iamluc.

Member

nicolas-grekas commented Sep 26, 2017

Thank you @iamluc.

@nicolas-grekas nicolas-grekas merged commit 4a01cd8 into symfony:3.3 Sep 26, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 26, 2017

bug #24251 [PropertyAccess] Set a NullLogger in ApcuAdapter when Apcu…
… is disabled in CLI (iamluc)

This PR was merged into the 3.3 branch.

Discussion
----------

[PropertyAccess] Set a NullLogger in ApcuAdapter when Apcu is disabled in CLI

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Same check as in https://github.com/symfony/symfony/pull/23390/files#diff-a5185cd58702e8e073786794a423cb27R112

Commits
-------

4a01cd8 Set a NullLogger in ApcuAdapter when Apcu is disabled in CLI

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment