New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel][DI] Enable Kernel to implement CompilerPassInterface #24257

Closed
wants to merge 2 commits into
base: 3.4
from

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Sep 19, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

In the same spirit as #13761 that allowed DI exts to be also compiler passes, and as #23812 that allowed the kernel to listen to events, in our new bundle-less world, should we allow the kernel to register itself as a compiler pass? That would make some scenario possible (like having a TestKernel that turns some services public.)

@fabpot

fabpot approved these changes Sep 19, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Sep 20, 2017

Member

@ogizanagi comments addressed.

Member

nicolas-grekas commented Sep 20, 2017

@ogizanagi comments addressed.

@@ -4,6 +4,7 @@ CHANGELOG
3.4.0
-----
* moved the `ExtensionCompilerPass` to before-optimization passes with priority -1000

This comment has been minimized.

@xabbuh

xabbuh Sep 20, 2017

Member

may be worth adding this to the upgrade file too

@xabbuh

xabbuh Sep 20, 2017

Member

may be worth adding this to the upgrade file too

This comment has been minimized.

@nicolas-grekas
@nicolas-grekas
@xabbuh

xabbuh approved these changes Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment