New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBundle] Remove profiler related scripting #24281

Merged
merged 2 commits into from Sep 26, 2017

Conversation

Projects
None yet
5 participants
@ro0NL
Contributor

ro0NL commented Sep 21, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

For sanity.

Also in case of an exception page we conflict with the profiler scripting/css.

Uncaught TypeError: Cannot set property 'className' of null

Happens because Sfjs.createTabs from the profiler tries to process tabs again, which twig has already done. The code doesnt handle this gracefully.

In case of ajax request (edgy yes) we see the CSS conflicting;

image

Note the table borders. Not sure how and if we want to solve this nor what it might affect otherwise; open for now.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 26, 2017

Member

Thank you @ro0NL.

Member

fabpot commented Sep 26, 2017

Thank you @ro0NL.

@fabpot fabpot merged commit eb520e1 into symfony:3.3 Sep 26, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 26, 2017

bug #24281 [TwigBundle] Remove profiler related scripting (ro0NL, jav…
…iereguiluz)

This PR was merged into the 3.3 branch.

Discussion
----------

[TwigBundle] Remove profiler related scripting

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

For sanity.

Also in case of an exception page we conflict with the profiler scripting/css.

```
Uncaught TypeError: Cannot set property 'className' of null
```

Happens because `Sfjs.createTabs` from the profiler tries to process tabs again, which twig has already done. The code doesnt handle this gracefully.

In case of ajax request (edgy yes) we see the CSS conflicting;

![image](https://user-images.githubusercontent.com/1047696/30712781-7680c8d2-9f0d-11e7-8a6c-27f460c1e780.png)

Note the table borders. Not sure how and if we want to solve this nor what it might affect otherwise; open for now.

Commits
-------

eb520e1 Minor reword
02dcdca [TwigBundle] Remove profiler related scripting

@ro0NL ro0NL deleted the ro0NL:ajax branch Sep 27, 2017

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment