New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnitBridge] don't remove when set to empty string #24379

Merged
merged 1 commit into from Sep 30, 2017

Conversation

Projects
None yet
3 participants
@Simperfit
Contributor

Simperfit commented Sep 29, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23955
License MIT
Doc PR

Fix a bug when passing empty string symfony/yaml and phpspec/prophecy

@fabpot

fabpot approved these changes Sep 30, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 30, 2017

Member

Thank you @Simperfit.

Member

fabpot commented Sep 30, 2017

Thank you @Simperfit.

@fabpot fabpot merged commit 722872f into symfony:3.3 Sep 30, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 30, 2017

bug #24379 [PHPUnitBridge] don't remove when set to empty string (Sim…
…perfit)

This PR was merged into the 3.3 branch.

Discussion
----------

[PHPUnitBridge] don't remove when set to  empty string

| Q             | A
| ------------- | ---
| Branch?       |3.3
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23955
| License       | MIT
| Doc PR        |

Fix a bug when passing empty string symfony/yaml and phpspec/prophecy

Commits
-------

722872f [PHPUnitBridge] don't remove when set to  empty string

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment