New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Removed dead code in the start method #24395

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
5 participants
@lyrixx
Member

lyrixx commented Oct 2, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@nicolas-grekas nicolas-grekas added this to the 4.0 milestone Oct 2, 2017

@fabpot

fabpot approved these changes Oct 5, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Oct 5, 2017

Member

Thank you @lyrixx.

Member

fabpot commented Oct 5, 2017

Thank you @lyrixx.

@fabpot fabpot merged commit 1eee2a4 into symfony:master Oct 5, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 5, 2017

minor #24395 [Process] Removed dead code in the start method (lyrixx)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Process] Removed dead code in the start method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

1eee2a4 [Process] Removed dead code in the start method

@lyrixx lyrixx deleted the lyrixx:process-start branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment