New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] treat trailing backslashes in multi-line strings #24416

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
6 participants
@xabbuh
Member

xabbuh commented Oct 3, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24408
License MIT
Doc PR
@faheemhameed

This comment has been minimized.

Show comment
Hide comment
@faheemhameed

faheemhameed Oct 4, 2017

This works great. Thanks!! Will this be merged to "symfony/symfony": "3.3.3" so that I can pull the new version easily? or how can I do it. I am quite a newbie here.

faheemhameed commented Oct 4, 2017

This works great. Thanks!! Will this be merged to "symfony/symfony": "3.3.3" so that I can pull the new version easily? or how can I do it. I am quite a newbie here.

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz Oct 4, 2017

Member

@faheemhameed if accepted, this will be merged in 3.3 branch and it will be available in the next stable version released for Symfony 3.3. If you need this solution as soon as possible, you could even use a forked version of this component in your composer.json or even, copy+paste this change in the specific file inside vendor/ (this las "solution" only recommended in case of real urgency!).

Member

javiereguiluz commented Oct 4, 2017

@faheemhameed if accepted, this will be merged in 3.3 branch and it will be available in the next stable version released for Symfony 3.3. If you need this solution as soon as possible, you could even use a forked version of this component in your composer.json or even, copy+paste this change in the specific file inside vendor/ (this las "solution" only recommended in case of real urgency!).

@faheemhameed

This comment has been minimized.

Show comment
Hide comment
@faheemhameed

faheemhameed Oct 5, 2017

@javiereguiluz Thanks for the guide. I have tried to create a fork and tried to update my composer.json using vcs repo based on a note I found in the getcomposer.org website. But it was not successful. I have decided to wait for the update as the issue is not a pressing one for me.

Many thanks.

faheemhameed commented Oct 5, 2017

@javiereguiluz Thanks for the guide. I have tried to create a fork and tried to update my composer.json using vcs repo based on a note I found in the getcomposer.org website. But it was not successful. I have decided to wait for the update as the issue is not a pressing one for me.

Many thanks.

@fabpot

fabpot approved these changes Oct 5, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Oct 5, 2017

Member

Thank you @xabbuh.

Member

fabpot commented Oct 5, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 80af9b8 into symfony:3.3 Oct 5, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 5, 2017

bug #24416 [Yaml] treat trailing backslashes in multi-line strings (x…
…abbuh)

This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] treat trailing backslashes in multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24408
| License       | MIT
| Doc PR        |

Commits
-------

80af9b8 treat trailing backslashes in multi-line strings

@xabbuh xabbuh deleted the xabbuh:issue-24408 branch Oct 5, 2017

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment