New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Fix broken tests for PHP 7.2 #24516

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@sroze
Member

sroze commented Oct 11, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #24524, #24515
License MIT
Doc PR ø

Following #24515, trying to fix Process tests with PHP 7.2

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Oct 11, 2017

Member

Status: needs work
Reason: tests are not actually running and it's only running PHP 7.2 for now

Member

sroze commented Oct 11, 2017

Status: needs work
Reason: tests are not actually running and it's only running PHP 7.2 for now

@sroze sroze changed the title from PHP 7.2 Process tests to Process & HttpFoundation tests for PHP 7.2 Oct 11, 2017

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 11, 2017

Member

you should avoid it being marked as an intermediary version though. You don't want it to be skipped.

Member

stof commented Oct 11, 2017

you should avoid it being marked as an intermediary version though. You don't want it to be skipped.

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Oct 12, 2017

Member

@stof do you think we should prevent 7.2 to be marked as intermediate for all the PRs or it was just in the context of my debugging?

Member

sroze commented Oct 12, 2017

@stof do you think we should prevent 7.2 to be marked as intermediate for all the PRs or it was just in the context of my debugging?

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Oct 12, 2017

Member

Status: Needs Review

Member

sroze commented Oct 12, 2017

Status: Needs Review

@nicolas-grekas nicolas-grekas added this to the 4.0 milestone Oct 12, 2017

matrix:
include:
- php: 7.1.3
- php: 7.1
env: deps=high
- php: 7.1
- php: 7.2

This comment has been minimized.

@Simperfit

Simperfit Oct 12, 2017

Contributor

maybe we could add without deps=low too

@Simperfit

Simperfit Oct 12, 2017

Contributor

maybe we could add without deps=low too

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Oct 12, 2017

Member

nope: the matrix is optimized to test the maximum of cases with the minimum number of jobs

@nicolas-grekas

nicolas-grekas Oct 12, 2017

Member

nope: the matrix is optimized to test the maximum of cases with the minimum number of jobs

@sroze sroze changed the title from Process & HttpFoundation tests for PHP 7.2 to [Process] Fix broken tests for PHP 7.2 Oct 12, 2017

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Oct 12, 2017

Member

@nicolas-grekas as discussed, kept here only the process test change and travis configuration and moved the native session storage PR to #24531 to target 2.7.

Member

sroze commented Oct 12, 2017

@nicolas-grekas as discussed, kept here only the process test change and travis configuration and moved the native session storage PR to #24531 to target 2.7.

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Oct 12, 2017

Member

And rebased. Tests are logically still failing because of the HttpFoundation bug fixed in #24531.

Member

sroze commented Oct 12, 2017

And rebased. Tests are logically still failing because of the HttpFoundation bug fixed in #24531.

sroze added some commits Oct 11, 2017

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Nov 6, 2017

Member

Rebased and now 💚.

/cc @xabbuh

Member

sroze commented Nov 6, 2017

Rebased and now 💚.

/cc @xabbuh

@xabbuh

xabbuh approved these changes Nov 6, 2017

@chalasr

chalasr approved these changes Nov 6, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Nov 6, 2017

Member

Thank you @sroze.

Member

nicolas-grekas commented Nov 6, 2017

Thank you @sroze.

nicolas-grekas added a commit that referenced this pull request Nov 6, 2017

minor #24516 [Process] Fix broken tests for PHP 7.2 (sroze)
This PR was squashed before being merged into the 4.0-dev branch (closes #24516).

Discussion
----------

[Process] Fix broken tests for PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #24524, #24515
| License       | MIT
| Doc PR        | ø

Following #24515, trying to fix Process tests with PHP 7.2

Commits
-------

b410a36 [Process] Fix broken tests for PHP 7.2

@sroze sroze deleted the sroze:process-and-php72 branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment