Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[DependencyInjection] fixed PhpDumper + as_files + new lines in string arguments/properties/etc of Definitions #24517
If I remove your change in PhpDumper, I get this change in the fixtures file:
-return $this->services['foo'] = new \Foo('string with' . "\n" . 'new line'); +return $this->services['foo'] = new \Foo('string with +');
The code without your change is thus perfectly fine.
@nicolas-grekas yes. Generated code become invalid if test case changed from
UPD, just tested that, it compiles to: